Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP-1175: Update HTTP interface specification to match the new design #112

Merged
merged 11 commits into from
Mar 7, 2024

Conversation

thaapasa
Copy link
Contributor

Update architecture model based on the new design. This will break backwards-compatibility with older versions.

tests/conftest.py Outdated Show resolved Hide resolved
src/iqm/iqm_client/iqm_client.py Outdated Show resolved Hide resolved
@kukushechkin
Copy link
Contributor

I would also add a changeling with the major version change that will probably be used once this is merged into the mainstream.

@thaapasa
Copy link
Contributor Author

I would also add a changeling with the major version change that will probably be used once this is merged into the mainstream.

I've added some initial log entry that describes the changes generally

@thaapasa
Copy link
Contributor Author

The main iqm_client file has become quite large, so I extracted quantum_architecture.py and instruction.py from it and added some supporting operations there. If you wish to keep all these together in a single file (as it was), let me know, I can merge them back in. It looked to me that we could benefit from splitting the code into smaller pieces.

src/iqm/iqm_client/util.py Outdated Show resolved Hide resolved
@thaapasa thaapasa force-pushed the COMP-1175-new-http-interface branch 4 times, most recently from 2b45785 to fa7b594 Compare January 30, 2024 09:07
@thaapasa thaapasa marked this pull request as ready for review February 27, 2024 12:22
Co-authored-by: Janne Kotilahti <83180458+jkotilahti@users.noreply.github.com>
@freetonik freetonik self-requested a review March 6, 2024 13:51
@freetonik freetonik merged commit 193e0f3 into main Mar 7, 2024
13 checks passed
@freetonik freetonik deleted the COMP-1175-new-http-interface branch March 7, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants