COMP-325 Add support for Python 3.10 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current pinned versions of testing dependencies do not support Python v3.10 and need to be upgraded, specifically, mypy v0.812 and its sub-dependency typed-ast v1.4.3. Use the opportunity to upgrade all testing dependencies to the latest available versions
Use Github Actions build matrix feature to specify Python versions
hay-k
reviewed
Apr 11, 2022
|
The line |
|
@hay-k, according to this https://peps.python.org/pep-0440/#compatible-release, ~= 3.9 equals to >= 3.9, == 3.* which should cover versions 3.9 and 3.10. Or did I get this wrong? |
Co-authored-by: Hayk Sargsyan <52532457+hay-k@users.noreply.github.com>
If the name of environment matches a specific format, Tox can parse it and deduce the version of Python to be used
Yes, you are correct, no need to change that one |
This Tox feature is called "generative section names". It will run directives in all environments that match name pattern of the section
Add link to Tox ticket. If/when implemented it would allow to simplify the construction of Tox test environment names in Github, as Tox would support more formats of how to specify Python version information
These were used for troubleshooting environment setup during development and can now be removed
Tox environemtn name is anyway printed later in the logs by Tox itself
Previously the environment variables were used, but they are not needed
hay-k
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.