Move settings from IQMClients constructor to submit_circuit #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonWubben
force-pushed
the
submit-circuit-takes-station-control-settings
branch
from
6b8d3b2
to
e335375
Compare
LeonWubben
force-pushed
the
submit-circuit-takes-station-control-settings
branch
from
40402cd
to
347d945
Compare
LeonWubben
force-pushed
the
submit-circuit-takes-station-control-settings
branch
from
226c4ca
to
4cca4b8
Compare
smite
reviewed
Jun 16, 2022
ollityrkko
previously approved these changes
Aug 8, 2022
kukushechkin
reviewed
Aug 8, 2022
smite
reviewed
Aug 8, 2022
smite
reviewed
Aug 8, 2022
Co-authored-by: Ville Bergholm <1044345+smite@users.noreply.github.com>
kukushechkin
previously approved these changes
Aug 9, 2022
smite
reviewed
Aug 9, 2022
smite
reviewed
Aug 9, 2022
Co-authored-by: Ville Bergholm <1044345+smite@users.noreply.github.com>
smite
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to remove the need to initialize a new client when running a circuit with new settings, the settings are now moved from the constructor to
submit_circuit