Add utility function to_json_dict
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollityrkko
requested review from
kukushechkin,
smite,
freetonik,
hay-k,
jkotilahti,
q-mat-beu and
rbrazinskas
kukushechkin
reviewed
Mar 9, 2023
CHANGELOG.rst
Outdated
| Version 11.7 | ||
| ============ | ||
|
|
||
| * Add utility function ``to_json_dict`` to convert a dict to a JSON dict. `#76 <https://github.com/iqm-finland/iqm-client/pull/76>`_ |
| return JSONEncoder.default(self, o) | ||
|
|
||
|
|
||
| def to_json_dict(obj: dict[str, Any]) -> dict: |
There was a problem hiding this comment.
Is it supposed to be used anywhere in iqm-client or just for the users? If for users, there should probably be an example in readme or docs.
There was a problem hiding this comment.
It is not used anywhere in iqm-client, and it is not really intended for users as such, but rather for integrators.
First use will be in qiskit-on-iqm.
I added a short paragraph of it in integration guide.
kukushechkin
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function can be used to sanitise data (e.g. circuit metadata) before sending it IQMClient.