COMP-781: Validate input arguments #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<humanize> is used to generate ordinals for user-friendly error messages <pylint-pydantic> is used to suppress pylint warning from custom pydantic validators (no-self-argument)
The implementation uses custom validators in pydantic models. Also, pydantic models are moved into a separate file as the original module was getting too large according to pylint (>1k LoC)
The validator is for the <implementation> field of the <Instruction>
ollityrkko
previously approved these changes
Apr 19, 2023
… comp-781-validate-input-arguments
|
@ollityrkko, could you take one more look? Review is required again after solving the merge conflicts |
ollityrkko
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement circuit validation using custom validators in Pydantic models