Fix Datasets API getVersionFiles endpoint content type filtering #10017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landreev
approved these changes
Oct 16, 2023
landreev
added this to Ready for Review ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
landreev
moved this from Ready for Review ⏩
to Ready for QA ⏩
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Ready for QA ⏩
to Done 🚀
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
DatasetsIT.getVersionFiles fails intermittently as it sometimes finds out unordered files when sorting by content type.
A second orderBy condition has been added to force that when sorting by content type, files are also sorted by name.
New order example:
Suggestions on how to test this:
Get dataset files via curl using contentType query param:
curl "https://demo.dataverse.org/api/datasets/24/versions/1.0/files?contentType=image/png"