-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10112-ProvIT-enable-fix #10113
10112-ProvIT-enable-fix #10113
Conversation
I made an additional change to this PR; Initially, I expressed concerns by messing with permanent settings during the test. The first change enables and then disables the provenance collection setting, this prevents the test from failing but then I realized by doing this, that if the setting was initially on, running this test would leave it off. I decided to check the status of the setting and only enable it if it wasn't initially, and then disable it only if it was modified during the test. This may not affect this test but probably if someone else is using this setting is better just to leave it on the status that it was found before the test. |
In 3407fb9 I enabled the test to run automatically in our CI. For more on the file I edited: https://guides.dataverse.org/en/6.0/developers/testing.html#writing-api-tests-with-rest-assured Update: it passed. See https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10113/3/testReport/edu.harvard.iq.dataverse.api/ProvIT/ |
https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10113/4/ failed but I made a couple formatting commits and will re-check after the API tests run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing at https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10113/5/testReport/edu.harvard.iq.dataverse.api/ProvIT/
I'm merging this.
What this PR does / why we need it:
The ProvIT test is not working correctly due to the feature not being enabled.
Which issue(s) this PR closes:
Closes #10112
Special notes for your reviewer:
This change will enable the feature and delete the setting at the end of the test.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
N/A
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A