Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10112-ProvIT-enable-fix #10113

Merged
merged 6 commits into from
Nov 14, 2023
Merged

Conversation

jp-tosca
Copy link
Contributor

@jp-tosca jp-tosca commented Nov 9, 2023

What this PR does / why we need it:
The ProvIT test is not working correctly due to the feature not being enabled.

Which issue(s) this PR closes:

Closes #10112

Special notes for your reviewer:
This change will enable the feature and delete the setting at the end of the test.

Suggestions on how to test this:

  1. Check out the repo
  2. Start docker, mvn -Pct clean package docker:run
  3. Run the test, mvn test -Dtest=ProvIT

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
N/A

Is there a release notes update needed for this change?:
N/A

Additional documentation:
N/A

@jp-tosca jp-tosca added Type: Bug a defect Size: 0.5 A percentage of a sprint. 0.35 hours labels Nov 9, 2023
@jp-tosca jp-tosca added this to Ready for Review ⏩ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) via automation Nov 9, 2023
@jp-tosca
Copy link
Contributor Author

I made an additional change to this PR; Initially, I expressed concerns by messing with permanent settings during the test.

The first change enables and then disables the provenance collection setting, this prevents the test from failing but then I realized by doing this, that if the setting was initially on, running this test would leave it off.

I decided to check the status of the setting and only enable it if it wasn't initially, and then disable it only if it was modified during the test.

This may not affect this test but probably if someone else is using this setting is better just to leave it on the status that it was found before the test.

@pdurbin
Copy link
Member

pdurbin commented Nov 13, 2023

@pdurbin pdurbin self-assigned this Nov 13, 2023
@pdurbin pdurbin moved this from Ready for Review ⏩ to In Review 🔎 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Nov 13, 2023
@pdurbin
Copy link
Member

pdurbin commented Nov 13, 2023

https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10113/4/ failed but I made a couple formatting commits and will re-check after the API tests run.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from In Review 🔎 to Ready for QA ⏩ Nov 14, 2023
@pdurbin pdurbin merged commit 3305c4a into IQSS:develop Nov 14, 2023
11 checks passed
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Ready for QA ⏩ to Done 🚀 Nov 14, 2023
@pdurbin pdurbin added this to the 6.1 milestone Nov 14, 2023
@pdurbin pdurbin removed their assignment Nov 14, 2023
@jp-tosca jp-tosca deleted the 10112-ProvIT-enable-fix branch February 18, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 0.5 A percentage of a sprint. 0.35 hours Type: Bug a defect
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

ProvIT test failing due provenance metadata being disabled.
2 participants