3322 Empty OAI sets should not be listed in ListSets #10228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ering the harvesting server page. #3322
This comment has been minimized.
This comment has been minimized.
|
Please note that the HarvestingServer API tests require the following jvm options: This info is in the guide, but may be a bit buried. |
sekmiller
approved these changes
Jan 16, 2024
|
(I just kicked off a Jenkins run manually) |
|
Checked in a better definition for the test in the PR. Test is passing locally, Jenkins run is in progress. |
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Another OAI issue that's 7 years old, but still valid.
Pretty straightforward: when an OAI set is created, it should not be shown in ListSets until it is successfully exported and contains 1 or more dataset records.
Which issue(s) this PR closes:
Closes #3322
Special notes for your reviewer:
Slightly out of scope, but while I was at it, I noticed that the harvesting server page had some calls requiring potentially non-trivial database lookups in the rendering logic rules. This is likely making our own prod. harvesting server page take 7 times longer to load.
Made the page cache these numbers (7 times = the number of times rendering logic rules are evaluated)
Suggestions on how to test this:
Create a set or two, via the API or the UI, experiment.
When creating a set on the harvesting server dashboard page, it is exported right away. So the easiest way to test this would be to create a set that doesn't match any records. With a query like
dsPersistentId:NOSUCHID. Confirm that the set isn't shown in the output of the OAI ListSets.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: