Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bad SQL query in guestbook #10232 #10233

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix bad SQL query in guestbook #10232 #10233

merged 1 commit into from
Jan 17, 2024

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Jan 12, 2024

What this PR does / why we need it:

Without this fix it's possible get 500 error like this when you land on a dataset page:

Screenshot 2024-01-12 at 12 23 41 PM

Which issue(s) this PR closes:

Special notes for your reviewer:

None.

Suggestions on how to test this:

mvn test -Dtest=FilesIT#testAddTinyFile

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

No.

Additional documentation:

None.

@coveralls
Copy link

Coverage Status

coverage: 20.154%. remained the same
when pulling 5e9cc2f on 10232-guestbook
into 39794d5 on develop.

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10232-guestbook
ghcr.io/gdcc/configbaker:10232-guestbook

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@cmbz cmbz added the Size: 3 A percentage of a sprint. 2.1 hours. label Jan 16, 2024
@sekmiller sekmiller self-assigned this Jan 17, 2024
@sekmiller sekmiller merged commit 0a656ce into develop Jan 17, 2024
18 checks passed
@sekmiller sekmiller deleted the 10232-guestbook branch January 17, 2024 16:53
@pdurbin pdurbin added this to the 6.2 milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

GuestbookResponseServiceBean: PSQLException: ERROR: trailing junk after numeric literal at or near "3a"
5 participants