Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10212 PR refactor proposal for GetLatestPublishedDatasetVersionCommand #10267

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Jan 25, 2024

What this PR does / why we need it:

This PR proposes a refactoring to improve readability in GetLatestPublishedDatasetVersionCommand and avoid having to use comments to explain the behavior.

Related PR: #10212

Which issue(s) this PR closes:

N/A

Special notes for your reviewer:

Tests passing

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

N/A

Is there a release notes update needed for this change?:

N/A

Additional documentation:

N/A

@GPortas GPortas marked this pull request as ready for review January 25, 2024 11:55
@GPortas GPortas requested a review from jp-tosca January 25, 2024 12:03
@coveralls
Copy link

coveralls commented Jan 25, 2024

Coverage Status

coverage: 20.167%. remained the same
when pulling e59907b on 10212-refactor-get-latest-published-dsv-cmd
into 6729284 on 10207-bug-api-datasets-versions-latest-fix.

This comment has been minimized.

1 similar comment
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10212-refactor-get-latest-published-dsv-cmd
ghcr.io/gdcc/configbaker:10212-refactor-get-latest-published-dsv-cmd

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@jp-tosca jp-tosca merged commit 3a4cab1 into 10207-bug-api-datasets-versions-latest-fix Jan 26, 2024
19 checks passed
@jp-tosca jp-tosca deleted the 10212-refactor-get-latest-published-dsv-cmd branch January 26, 2024 16:24
@cmbz cmbz added the Size: 3 A percentage of a sprint. 2.1 hours. label Jan 30, 2024
@pdurbin pdurbin added this to the 6.2 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

None yet

5 participants