#9748 delete tools only added by tests #10274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
scolapasta
requested changes
Jan 26, 2024
| @@ -145,26 +130,14 @@ public void testFileLevelTool1() { | |||
| .statusCode(OK.getStatusCode()) | |||
| // No tools for this file type. | |||
| .body("data", Matchers.hasSize(0)); | |||
|
|
|||
| //Delete the tool added by this test... | |||
| Response deleteExternalTool = UtilIT.deleteExternalTool(toolId); | |||
There was a problem hiding this comment.
@sekmiller for the other delete, you follow with an:
deleteExternalTool.then().assertThat()
.statusCode(OK.getStatusCode());
For consistency can you add that here?
This comment has been minimized.
This comment has been minimized.
scolapasta
approved these changes
Jan 26, 2024
|
There's a test failure at https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10274/1/testReport/edu.harvard.iq.dataverse.api/ExternalToolsIT/testFileLevelTool1/ Seems like an easy fix: |
|
Weird. It's not failing for me locally. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
pdurbin
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Updates ExternalToolsIT so that existing tools are not deleted
Which issue(s) this PR closes:
Closes #9748 Installed External tools deleted by running ExternalToolsIT
Special notes for your reviewer: Going in I thought that deleting the tools was a requirement to get the tests to pass. That turned out not to be the case which made the fix easier. The tests were modified to delete only those tools added via the tests.
Suggestions on how to test this: Install an external tool in your test environment. Run ExternalToolsIT
verify that your pre-installed tool(s) exist after running the test. And that there are no additional tools.
api for getting a list of installed tools:
curl http://localhost:8080/api/admin/externalTools
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?: no
Additional documentation: none