10297 dataset metadata endpoint fix #10303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
|
Tests are passing at https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10303/1/testReport/ Looks good. Lots of tests added. I don't think it's worth adding this to the API Changelog, honestly. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When trying to access the endpoint api/datasets/{id}/metadata it will try by default to get the draft version and if this endpoint is used on a dataset with no draft it will return an error specifying that there is no draft version accompanied by an exception on the server side.
Which issue(s) this PR closes:
Closes #10297
Special notes for your reviewer: It was discussed on slack that this was the intended behavior of the endpoint. Tests were added to validate when multiple versions of the dataset exist.
Suggestions on how to test this:
Try to access the endpoint at
api/datasets/{id}/metadataIf a draft exists and the user has access to it it should be prioritized, otherwise, a published version will provided if exists.
Is there a release notes update needed for this change?:
Yes.