Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade configbaker to Alpine 3.18 #10414

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

poikilotherm
Copy link
Contributor

@poikilotherm poikilotherm commented Mar 22, 2024

What this PR does / why we need it:
Must downgrade to Alpine 3.18 to fix curl DNS issues.

Which issue(s) this PR closes:

Special notes for your reviewer:
Hold the review until we had an affected user test it.

Suggestions on how to test this:
Use the GHCR image of configbaker.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No

Is there a release notes update needed for this change?:
No

Additional documentation:
None.

@poikilotherm poikilotherm added Size: 0.5 A percentage of a sprint. 0.35 hours Component: Containers Anything related to cloudy Dataverse, shipped in containers. labels Mar 22, 2024
@poikilotherm poikilotherm self-assigned this Mar 22, 2024
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I have a question about the comment.

modules/container-configbaker/Dockerfile Show resolved Hide resolved
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10413-configbaker-alpine-downgrade
ghcr.io/gdcc/configbaker:10413-configbaker-alpine-downgrade

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see at https://dataverse.zulipchat.com/#narrow/stream/375812-containers/topic/demo.20tutorial.20issues/near/428366690 this working for @nightowlaz so I'm approving it.

@poikilotherm this is still in draft. Are you ready for it to be merged?

@poikilotherm
Copy link
Contributor Author

Yes, this is good to go. Can't convert on my mobile, could you plz?

@poikilotherm
Copy link
Contributor Author

I assume as 6.2 is days away, we will not adapt the Demo tutorial?

@pdurbin pdurbin marked this pull request as ready for review March 22, 2024 18:00
@pdurbin pdurbin merged commit 4c33a5c into develop Mar 22, 2024
6 checks passed
@pdurbin pdurbin deleted the 10413-configbaker-alpine-downgrade branch March 22, 2024 18:01
@pdurbin pdurbin added this to the 6.2 milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers. Size: 0.5 A percentage of a sprint. 0.35 hours
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Downgrade configbaker to Alpine 3.18 base image
2 participants