fixing bug with tabs in log line for MDC #10416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenwinship
added
NIH OTA: 1.5.1
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
qqmyers
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Makes sense - gets rid of tabs that cause issues and I don't think any of this info is used outside counter-processor so any transform that doesn't result in false matches should be OK (and we wouldn't expect anything differing only by whitespace to really be different as far as c-p cares.).
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log lines for MDC must be tab delimited but in some cases the data in the lines contain tabs which throws off the columns.
Replace the tabs with spaces in MakeDataCountLoggingServiceBean.
In this example the authors column(14) contains 2 tabs adding 2 additional columns causing an error in counter_processor
ex:
2024-03-21 15:17:49 importing log/counter_2024-02-01.log
line is wrong: 2024-02-01T00:13:30-0500 98.121.236.139 - - :guest https://dataverse.harvard.edu/api/v1/datasets/export?exporter=schema.org&persistentId=doi%3A10.7910%2FDVN%2FJ1UD6S doi:10.7910/DVN/J1UD6S - - python-requests/2.28.2 Main Cities grid tbd 00_metadata 00_metadata 100% 10 Digital Map Database of China 已启用屏幕阅读器支持。 Digital Map Database of China 2020-02-15T21:35:14Z 1 - https://dataverse.harvard.edu/api/v1/datasets/export?exporter=schema.org&persistentId=doi%3A10.7910%2FDVN%2FJ1UD6S 2020
Which issue(s) this PR closes:
Needed for IQSS/dataverse.harvard.edu#3
Special notes for your reviewer:
Suggestions on how to test this:
Make sure the log file has no extra tabs
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: No
Additional documentation: None