10254 fixing redirects for records harvested from "Generic OAI archives" (i.e., non-Dataverse OAI servers) #10430
+19
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In 6.1, redirects for harvested records are broken as described in the title (because the init() method in the dataset page returns something jsf no longer likes).
Note that the fix in the PR was already included in the 6.1 patch deployed in IQSS prod., and is the reason the redirects are working properly in the SRDA collection (our only "generic", non-Dataverse harvested collection at the moment).
Which issue(s) this PR closes:
Closes #10254
Special notes for your reviewer:
Suggestions on how to test this:
Running develop, if you harvest the ControlSetTest from demo, with the "Generic OAI server" in the configuration, an attempt to click on the search card for each harvested dataset will result in a messy 500.
https://demo.dataverse.org/dataset.xhtml?persistentId=doi:
- this will make the redirects back to demo actually work (i.e., it will be using the url you entered for the redirects, instead of doi resolver used by default).An alternative QA: look at https://dataverse.harvard.edu/dataverse/srda_harvested in production where this fix is already deployed. Click on any search card, it should redirect you to the source properly.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: