Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10254 fixing redirects for records harvested from "Generic OAI archives" (i.e., non-Dataverse OAI servers) #10430

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

landreev
Copy link
Contributor

@landreev landreev commented Mar 26, 2024

What this PR does / why we need it:

In 6.1, redirects for harvested records are broken as described in the title (because the init() method in the dataset page returns something jsf no longer likes).

Note that the fix in the PR was already included in the 6.1 patch deployed in IQSS prod., and is the reason the redirects are working properly in the SRDA collection (our only "generic", non-Dataverse harvested collection at the moment).

Which issue(s) this PR closes:

Closes #10254

Special notes for your reviewer:

Suggestions on how to test this:

Running develop, if you harvest the ControlSetTest from demo, with the "Generic OAI server" in the configuration, an attempt to click on the search card for each harvested dataset will result in a messy 500.

  1. Simple fix number 1 from this PR: With this fix in place, the redirect will happen (it's still not going to work, mind you, it will attempt to redirect using the DOI resolver, and the dois demo uses are fake; but you will get a clean "no such doi" page from Datacite, and no 500s from your Dataverse).
  2. Simple fix number 2.: In the "Edit Harvsting Client", change the "Archive URL" (step 4. of the dialog) to https://demo.dataverse.org/dataset.xhtml?persistentId=doi: - this will make the redirects back to demo actually work (i.e., it will be using the url you entered for the redirects, instead of doi resolver used by default).

An alternative QA: look at https://dataverse.harvard.edu/dataverse/srda_harvested in production where this fix is already deployed. Click on any search card, it should redirect you to the source properly.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@landreev landreev added Feature: Harvesting Size: 3 A percentage of a sprint. 2.1 hours. labels Mar 26, 2024
@scolapasta scolapasta added this to the 6.2 milestone Mar 26, 2024

This comment has been minimized.

@sekmiller sekmiller self-assigned this Mar 27, 2024
@coveralls
Copy link

coveralls commented Mar 27, 2024

Coverage Status

coverage: 20.735% (-0.001%) from 20.736%
when pulling bb49ed0 on 10254-fix-harvested-redirects
into d5bb0c2 on develop.

This comment has been minimized.

1 similar comment
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10254-fix-harvested-redirects
ghcr.io/gdcc/configbaker:10254-fix-harvested-redirects

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@sekmiller sekmiller merged commit 834bd64 into develop Mar 28, 2024
19 checks passed
@sekmiller sekmiller deleted the 10254-fix-harvested-redirects branch March 28, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Harvesting Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Fix redirects to the original repository for "Generic OAI Archive"-type Harvesting Clients
4 participants