handle_dropdown_popup_scroll is not defined on permissions-manage.xhtml

[pameyer]

On 1178-1a12cda

Does not appear to prevent any functionality (was still able to modify user permissions on that page). Have not investigated sufficiently to see if it's related to #5589 , but that would be plausible. <script type="text/javascript" defer="defer" src="/javax.faces.resource/js/dv_rebind_bootstrap_ui.js.xhtml?version=4.10.1"></script> present in generated html

[mheppler]

There was some work done on dv_rebind_bootstrap_ui.js in #3925. I will take a look at the permissions-manage pg and see what I can sort out. Good catch, @pameyer.

[mheppler]

This function was added as part of commit ca9d9b9 for #4343, to the harvestclients, manage-groups, permissions-manage-files, provenance-popups-fragment, and role-assign pgs.

It resolves a scrolling issue with the dynamic dropdown menu for p:autoComplete components in popups on these pages.

Found the same reference errors on permissions-manage-files and manage-groups, but not harvestclients. Not sure what's going on here exactly.

[pameyer]

@mheppler Thanks for taking a look. This installation didn't have enough users that the dropdown would need to scroll (and for what it's worth, didn't have analytics enabled).

[kcondon]

On only one test machine, build, clicking save changes on the edit groups popup does not update list view and does not close popup but does save changes if cancel, then reload page.

The browser error in Chrome was:
manage-groups.xhtml?dataverseId=1:310 Uncaught ReferenceError: handle_dropdown_popup_scroll is not defined
at manage-groups.xhtml?dataverseId=1:310
(anonymous) @ manage-groups.xhtml?dataverseId=1:3

@mheppler Also saw this error in FF, which was in the analytics code:
XML Parsing Error: mismatched tag. Expected: .
Location: https://dvn-build.hmdc.harvard.edu/manage-groups.xhtml?dataverseId=1152
Line Number 150, Column 3:

[mheppler]

The XML parsing error is complaining about Line 150, and if you look in the browser page source for the manage groups pg on dvn-build, that line is the analytics code. The dvn-build server has the analytics code configured, and you see the XML error, demo does not have the analytics code, and there is no error.

There appears to be some javascript strangeness in the dataverse manage groups workflows, and it's probably worth investigating and resolving them all together.

[mheppler]

Due to UI bug this new console error is related to, I have spun it off into a new issue Manage Groups - Dialog popup does not close on save, action saved by system #6792. I hope that both console errors can still be resolved together.

[mheppler]

Rediscovered this javascript issue while looking at other javascript issues. Got a quick fix. Rather than putting the calls to this function on every page that uses it with the following code:

<script>
    handle_dropdown_popup_scroll();
</script>

I have instead moved that call to the bind_bsui_components() function that gets call when the document is ready...

    // Scrolling autoComplete dropdown in popups
    handle_dropdown_popup_scroll();

The reason you are seeing the ReferenceError in the console was because the inline code block under each autoComplete component was getting called before the javascript file was being loaded at the bottom of the page...

<script defer="defer" src="#{resource['js/dv_rebind_bootstrap_ui.js']}?version=#{systemConfig.getVersion()}"></script>

Now that the handle_dropdown_popup_scroll() function call has been moved to a more appropriate place, there are no more console ReferenceErrors, and the autoComplete dropdown menus are still displaying properly when you have a long list of options to scroll through.

Originally this code was added to the provenance code ca9d9b9 and other places where the autoComplete component is used.

Noticed a bug while I was poking at the test server. When using the entity connector dropdown on the add provenance window from the create dataset page, I used the scroll wheel on my mouse, and it caused the dropdown to move up and down on the screen while everything else stayed static:

This will be a good feature to revisit when working on Improve (simplify) Primefaces (Ajax) / Bootstrap interaction #7565.