OpenAIRE metadata export: fix how location information is expressed (production place and geospatial metadata)

[fcadili]

This Pull request is related to issue #6049. It fixes the location information generated by OpenAIRE export. For example, setting geolocation place to "Production Place" and geospatial metadata to [4, 3, 1, 2] and [d, c, a, b], we obtain as Openaire export:

<geoLocations>
	<geoLocation>
		<geoLocationPlace>Production Place</geoLocationPlace>
	</geoLocation>
	<geoLocation>
		<geoLocationBox>
			<northBoundLatitude>3</northBoundLatitude>
			<eastBoundLongitude>2</eastBoundLongitude>
			<westBoundLongitude>1</westBoundLongitude>
			<southBoundLatitude>4</southBoundLatitude>
		</geoLocationBox>
	</geoLocation>
	<geoLocation>
		<geoLocationBox>
			<northBoundLatitude>c</northBoundLatitude>
			<eastBoundLongitude>b</eastBoundLongitude>
			<westBoundLongitude>a</westBoundLongitude>
			<southBoundLatitude>d</southBoundLatitude>
		</geoLocationBox>
	</geoLocation>
</geoLocations>

Related Issues

• In OpenAIRE metadata export, fix how location information is expressed (production place and geospatial metadata) #6049: In OpenAIRE metadata export, fix how location information is expressed (production place and geospatial metadata)

[dataversebot]

Can one of the admins verify this patch?

[coveralls]

Coverage increased (+0.007%) to 19.489% when pulling 9349e08 on 4Science:openaire-6049 into 0c9a229 on IQSS:develop.

[pdurbin]

While we're in this code and QA'ing it, should we use this opportunity to replace "foo" here and elsewhere in this pull request with a word that's more meaningful?

[fcadili]

Could "set" be used instead of "foo"?

The pattern used in the code is the following:

for (HashSet<FieldDTO> foo : fieldDTO.getMultipleCompound()) {
         String awardNumber = null;
         String funderName = null;

          for (Iterator<FieldDTO> iterator = foo.iterator(); iterator.hasNext();) {
                 FieldDTO next = iterator.next();

Here the variable "foo" is used as a "general set".

[pdurbin]

@fcadili sure, "set" sounds much better than "foo" to me! 😄 Would it be a big change?

[fcadili]

It can be done (about 35 matches on OpenAireExportUtil or 17 code refactor).

[pdurbin]

@fcadili ok. We have standup in half an hour. I'll ask if we'd like this refactoring as part of this pull request or not. Please stay tuned!

@scolapasta @sekmiller what do you think?

[scolapasta]

Changing from foo is a good idea; rather than "set" I would suggest something that adds a little context to what is on the set, even if it's just "fieldDTOs".

[pdurbin]

@fcadili please change "foo" to "fieldDTOs" as @scolapasta suggested above. Thanks!!

[fcadili]

I've committed the new version with the required changes.

[pdurbin]

As of 9349e08 I'm fine with this from a code perspective (thanks, @fcadili !) but I know @jggautier spun up the branch to play with the feature and might have further feedback.

[jggautier]

As of 9349e08 I'm fine with this from a code perspective (thanks, @fcadili !) but I know @jggautier spun up the branch to play with the feature and might have further feedback.

Thanks so much for these improvements @fcadili and team! Changes to the OpenAIRE export look great to me. I have no further feedback :)