Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Groups - Dialog popup does not close on save, action saved by system #6792

Closed
mheppler opened this issue Apr 3, 2020 · 3 comments · Fixed by #7392
Closed

Manage Groups - Dialog popup does not close on save, action saved by system #6792

mheppler opened this issue Apr 3, 2020 · 3 comments · Fixed by #7392
Labels
Type: Bug a defect

Comments

@mheppler
Copy link
Contributor

mheppler commented Apr 3, 2020

On the Manage Groups pg, when editing an existing group in the Dataverse Group popup, the Save Changes btn silently saves the action, but does not close the popup. Checking the console, there is this XML parsing error when you click Save Changes.

XML Parsing Error: mismatched tag. Expected: </update>.
Location: .../manage-groups.xhtml?dataverseId=####
Line Number 150, Column 3:

There was also a console error ReferenceError: handle_dropdown_popup_scroll is not defined on the Manage Groups pg when it loads (#5653), but that does not appear to be related.

@kcondon initially discovered this on a test server, but could not reproduce it on another test server. One major difference between these two machines was the analytics button click event tracking code (http://guides.dataverse.org/en/4.20/installation/config.html#tracking-button-clicks) that was set up on the machine throwing the errors.

This bug is not on demo (4.19, no analytics), but it is on production (also 4.19) where the analytics event tracking code was added last month.

@pdurbin
Copy link
Member

pdurbin commented Nov 4, 2020

I can't reproduce this on develop (I'm on 3da9c40) so I'm sending this to QA to confirm. I tried Firefox and Chrome. In both cases, clicking "Create Group" closed the popup and I was left with a screen like this:

Screen Shot 2020-11-04 at 12 00 00 PM

@pdurbin
Copy link
Member

pdurbin commented Nov 4, 2020

In production on edit (not create) I was able to get the XML Parsing Error: mismatched tag. Expected: </update>. error when clicking "Save Changes":

Screen Shot 2020-11-04 at 12 26 49 PM

Thanks to @djbrooke for pointing out the bit about Google Analytics above. I'll keep digging.

Something else that struck me (I haven't used groups much) is that you can enter a description when you create a group but you can't edit or even see the description when you edit it. The description doesn't appear in the table either.

@pdurbin pdurbin moved this from Up Next 🛎 to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Nov 4, 2020
@djbrooke
Copy link
Contributor

djbrooke commented Nov 4, 2020

Thanks @pdurbin !!

@pdurbin pdurbin removed their assignment Nov 4, 2020
@pdurbin pdurbin removed this from IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Nov 4, 2020
pdurbin added a commit that referenced this issue Nov 12, 2020
This reverts commit e0fc1f8.

We're going to change @ALL instead.
kcondon added a commit that referenced this issue Nov 16, 2020
get dialog to close on Save Changes for groups #6792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants