Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edu.harvard.iq.dataverse.api.FilesIT.testUningestFileViaApi failing intermittently #6821

Closed
djbrooke opened this issue Apr 14, 2020 · 3 comments · Fixed by #6824
Closed

edu.harvard.iq.dataverse.api.FilesIT.testUningestFileViaApi failing intermittently #6821

djbrooke opened this issue Apr 14, 2020 · 3 comments · Fixed by #6824

Comments

@djbrooke
Copy link
Contributor

edu.harvard.iq.dataverse.api.FilesIT.testUningestFileViaApi has been failing intermittently over the last few test runs on dataverse.org Jenkins (416 is one build where this occurs). We should determine why this is occurring and get our test suite healthy.

@landreev
Copy link
Contributor

So it is the same test as in #6813 - except it was failing consistently for @pameyer. OK, must be some weird timing condition; we'll figure it out.
(it's probably unrelated, but there was a tiny change recently in how uningest works; we are now saving the original file name, rather than reconstructing it... I guess there's a possibility that it has changed the timing by some milliseconds, making this failure more likely? - who knows)

@pdurbin pdurbin self-assigned this Apr 15, 2020
@pdurbin pdurbin moved this from Up Next 🛎 to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Apr 15, 2020
@pdurbin
Copy link
Member

pdurbin commented Apr 15, 2020

I'm reliably getting a 500 error on my laptop. That is to say, I believe this issue is easy to reproduce.

UningestFileCommand.java:167 is implicated which does this:

MapLayerMetadata mapLayerMetadata = ctxt.mapLayerMetadata().findMetadataByDatafile(uningest);

I'm also seeing a lot of javax.validation.ConstraintViolationException:

Invalid value: <<>> for label at edu.harvard.iq.dvn.core.study.FileMetadata[id=784] - Please specify a file name.]]

pdurbin added a commit that referenced this issue Apr 15, 2020
The getOriginalFileName method only works on tabular files so call it
early before the file becomes non-tabular.
@pdurbin
Copy link
Member

pdurbin commented Apr 15, 2020

I just created pull request #6824

@pdurbin pdurbin removed their assignment Apr 15, 2020
kcondon added a commit that referenced this issue Apr 20, 2020
prevent label (filename) from being null #6821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants