Remove erroneous bit from codebook2-0.xsl (HTML Codebook stylesheet)

[johnhuck]

What this PR does / why we need it:
Removes an irrelevant hardcoded value ("ICPSR") in the HTML Codebook stylesheet.

Which issue(s) this PR closes:

Closes #6959

Special notes for your reviewer:
This updates my earlier pull request, based on discussion on the issue. Hope I did this right!

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:

[pdurbin]

I didn't test this but the code change looks fine.

[kcondon]

@pdurbin @johnhuck Seeing automated test failure on this branch, works in develop branch. It looks like the test is still looking for ICPSR in the comparison string. This is preventing me from building/deploying/testing:

[ERROR] Failures:
[ERROR] DdiExportUtilTest.testDatasetHtmlDDI:91 expected:<...

dct html ([ICPSR ]doi:10.5072/FK2/SOLY...> but was:<...

dct html ([]doi:10.5072/FK2/SOLY...>

[johnhuck]

thanks @kcondon and @pdurbin . I'm not sure what to do next. If the test is failing because it expects the string we want to remove, would it not be the case that the test needs to be modified?

[pdurbin]

@johnhuck that's exactly right. Based on the error above (line 91)...

It looks like you should remove "ICPSR " from src/test/resources/html/dct_codebook.html

I can see it's in there with "grep":

$ grep ICPSR src/test/resources/html/dct_codebook.html
<h1>dct html&nbsp;(ICPSR doi:10.5072/FK2/SOLYMR)</h1>

[johnhuck]

@pdurbin OK. And this is something you want me to do as well and submit another PR? I can figure out how to do that. Just want to confirm that that's what you want me to do.

[pdurbin]

@johnhuck sure, please give it a shot. If you have any trouble, please make sure we can push to your branch so we can do it.

[coveralls]

Coverage decreased (-0.03%) to 19.56% when pulling 9250585 on johnhuck:patch-1 into 97e7a60 on IQSS:develop.

[pdurbin]

I'm seeing https://travis-ci.org/github/IQSS/dataverse/builds/696173775 as of ff025fd so I'm moving this to QA. Thanks, @johnhuck

[pdurbin]

Looks good.

[kcondon]

@johnhuck This works great, thanks. Do you mind adding a release notes file that indicates that in order for previously published and exported datasets to reflect this correction, they need to be reexported, curl http://localhost:8080/api/admin/metadata/reExportAll

[pdurbin]

@johnhuck if you're not familiar with our release notes process, I would suggest creating a file at the following location:

doc/release-notes/6959-html-codebook.md

You can read more about the process at http://guides.dataverse.org/en/4.20/developers/making-releases.html#write-release-notes

[johnhuck]

@kcondon OK, I will do my best. This is good experience for me!

[pdurbin]

@johnhuck I edited the description...

... to have "Closes #6959" so that the issue will be closed when the pull request is merged. Here are a couple more screenshots:

[johnhuck]

@pdurbin @kcondon OK, I think this is ready. When you aren't busy with the community meeting, let me know if there's anything else I need to do (I don't know if the failing tests mean anything).

[pdurbin]

Looks good.