Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed render logic to add DRAFT to dataset links [ref #3038] #6969

Merged
merged 2 commits into from Jun 11, 2020

Conversation

mheppler
Copy link
Contributor

@mheppler mheppler commented Jun 8, 2020

What this PR does / why we need it:

Fixes the links (both title link AND icon link) on dataset cards on My Data pg so if it is a DRAFT you land on the draft version and not the latest published version.

Which issue(s) this PR closes:

Closes #3038 Draft Version URL Problem in "My Data"

Special notes for your reviewer:

My community mtg gift...

Suggestions on how to test this:

Log in as user who has access to a draft version of a dataset, that also has a published version, so that there are two cards displaying on My Data pg.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No, it if fixes a UI bug.

Is there a release notes update needed for this change?:

"My Data is not dead yet."

Additional documentation:

N/A

@coveralls
Copy link

coveralls commented Jun 8, 2020

Coverage Status

Coverage remained the same at 19.585% when pulling 9988e92 on 3038-my-data-draft-link-fix into 875ca66 on develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ Jun 8, 2020
@pdurbin pdurbin removed their assignment Jun 8, 2020
@kcondon kcondon self-assigned this Jun 11, 2020
@kcondon kcondon merged commit 676da97 into develop Jun 11, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jun 11, 2020
@kcondon kcondon deleted the 3038-my-data-draft-link-fix branch June 11, 2020 18:08
@djbrooke djbrooke added this to the Dataverse 5 milestone Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Draft Version URL Problem in "My Data"
5 participants