Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7001 Fix INPROGRESS typo. #7002

Merged
merged 1 commit into from Jun 22, 2020
Merged

#7001 Fix INPROGRESS typo. #7002

merged 1 commit into from Jun 22, 2020

Conversation

JingMa87
Copy link
Contributor

What this PR does / why we need it: Fix typo

Which issue(s) this PR closes: 7001

Closes #7001

Special notes for your reviewer: Most easiest fix

Suggestions on how to test this: Run a harvesting client and check the "Last Results" column

Does this PR introduce a user interface change? If mockups are available, please link/include them here: Smallest change imaginable

Is there a release notes update needed for this change?: No

Additional documentation:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.56% when pulling 6f2f22f on JingMa87:7001-harvest-inprogress-typo into 9fa0c2e on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a small, safe change to make, a good improvement. Thanks.

@JingMa87 after this gets merged, another improvement that could be made is to internationalize these strings, to move them to Bundle.properties. Especially when text appears in the UI, we try to make it translatable.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ Jun 18, 2020
@JingMa87
Copy link
Contributor Author

@pdurbin Good one, I'll keep it in mind!

@kcondon kcondon self-assigned this Jun 22, 2020
@kcondon kcondon merged commit 13e1a40 into IQSS:develop Jun 22, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jun 22, 2020
@JingMa87 JingMa87 deleted the 7001-harvest-inprogress-typo branch June 22, 2020 16:53
@djbrooke djbrooke added this to the Dataverse 5 milestone Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Typo while running a harvesting client
5 participants