Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7003 Fix log formatting and in particular the OAI URL. #7004

Merged
merged 2 commits into from Jun 22, 2020
Merged

#7003 Fix log formatting and in particular the OAI URL. #7004

merged 2 commits into from Jun 22, 2020

Conversation

JingMa87
Copy link
Contributor

What this PR does / why we need it: Fixes log formatting and in particular the OAI URL.

Which issue(s) this PR closes: 7003

Closes #7003

Special notes for your reviewer: Very easy fix

Suggestions on how to test this: Run a harvesting client on the server https://dataverse.harvard.edu/oai for the set AfricaRice and metadataprefix Datacite. Then check the harvest log for a logGetRecordException.

Does this PR introduce a user interface change? If mockups are available, please link/include them here: n/a

Is there a release notes update needed for this change?: No

Additional documentation:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.56% when pulling a4b338a on JingMa87:7003-bad-url into 9fa0c2e on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should improve readability.

@kcondon please note that the fix in #7002 ("in progress") is also in this pull request.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ Jun 18, 2020
@kcondon kcondon self-assigned this Jun 22, 2020
@kcondon kcondon merged commit ab3ec5f into IQSS:develop Jun 22, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jun 22, 2020
@JingMa87 JingMa87 deleted the 7003-bad-url branch June 22, 2020 16:54
@djbrooke djbrooke added this to the Dataverse 5 milestone Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Missing space in log causes bad URL
5 participants