Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI and accessibility clean up on dataverse, dataset and file pgs #7042

Merged
merged 1 commit into from Jul 2, 2020

Conversation

mheppler
Copy link
Contributor

@mheppler mheppler commented Jul 1, 2020

What this PR does / why we need it:

Minor UI clean up, and accessibility improvements to dataverse, dataset and file pgs.

Which issue(s) this PR closes:

Ref #6684 Layout and styling of action buttons on the dataset and file page

Special notes for your reviewer:

See following comment below for outline of changes. No new issue created, just piling onto the new button UI issue.

Suggestions on how to test this:

Simple smoke test for account creation, create dataset, publish, download, etc.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Minor UI clean and resolving accessibility issues identified in Siteimprove reports.

Is there a release notes update needed for this change?:

N/A

Additional documentation:

N/A

@mheppler
Copy link
Contributor Author

mheppler commented Jul 1, 2020

CONTACT

  • contact message textarea title description

LOGIN

  • change terms-agreement-block id's to class's on signup/login/password reset to fix "not unique" errors

DATAVERSE

  • add margin-bottom to actionButtonBlock to fix spacing between dataverse desc
  • add dataverse search input title description
  • improve responsive search, advanced search link for small viewports

DATASET

  • add "Select Files" aria-label to file table header
  • add "File Count" aria-label to file table header
  • add "File Actions" aria-label to file table header
  • fix spacing between btns in File Action table header
  • remove unnecessary link id's from tabular file download citation
  • change terms-agreement-block id's to class's on publish popup to fix "not unique" errors
  • add file table search input title description
  • add deaccession reason textarea title description
  • add terms of access input textarea title description
  • add return to author reason textarea title description
  • fix Terms of Access label for reference to input on download terms popup
  • fix Request Access label for reference to input on download terms popup

FILE

  • change i component to em for dataset title in file citation
  • fix Terms of Access label for reference to input on download terms popup
  • fix Request Access label for reference to input on download terms popup

Screen Shot 2020-07-01 at 11 14 48 AM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.557% when pulling 18d16f1 on 6684-additional-ui-cleanup into ce86fed on develop.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ Jul 1, 2020
@kcondon kcondon self-assigned this Jul 2, 2020
@kcondon kcondon merged commit 7de1c5b into develop Jul 2, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jul 2, 2020
@kcondon kcondon deleted the 6684-additional-ui-cleanup branch July 2, 2020 13:14
@djbrooke djbrooke added this to the Dataverse 5 milestone Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants