#6823 remove form update on file upload #7045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
added this to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
sekmiller
moved this from Code Review 🦁
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
scolapasta
reviewed
Jul 1, 2020
There was a problem hiding this comment.
Looks fine, but as @mheppler pointed out this @Form was originally added as part of the changes for dual mode. So I've asked @sekmiller to double check in that way to make sure that removing it doesn't break something there.
|
Verified that running in Dual Mode does not require the @Form update. |
sekmiller
moved this from IQSS Team - In Progress 💻
to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
scolapasta
approved these changes
Jul 7, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Code Review 🦁
to QA 🔎✅
Jul 7, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The page refresh that happens when a file is uploaded to a dataset in Create mode is annoying to users. This fix will leave the focus on the file upload section of the page
Which issue(s) this PR closes:
Closes #6823 Add Dataset after file upload browser jumps to top of page
Special notes for your reviewer:
Suggestions on how to test this:
Upload files via native on Dataset Create. Also run under dual mode with dcm and upload under native on DS Create,
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: