Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update account.rst #7063

Merged
merged 4 commits into from Jul 13, 2020
Merged

Update account.rst #7063

merged 4 commits into from Jul 13, 2020

Conversation

philippconzett
Copy link
Contributor

@philippconzett philippconzett commented Jul 8, 2020

Closes #7055

This PR adds information to the existing guide. Please feel free to adjust the formulation.

Please feel free to adjust the formulation.
@coveralls
Copy link

coveralls commented Jul 8, 2020

Coverage Status

Coverage remained the same at 19.653% when pulling 11e7a37 on philippconzett:patch-1 into 6daf219 on IQSS:develop.

@djbrooke
Copy link
Contributor

djbrooke commented Jul 8, 2020

Thanks @philippconzett !

@jggautier - would you be OK reviewing this PR and either making changes or working with @philippconzett on this?

@jggautier
Copy link
Contributor

jggautier commented Jul 8, 2020

Hi @philippconzett. I rewrote...

Another Dataverse user has requested access to a restricted file in one of your datasets (Note! A user with only the Contributor role will not get this notification. Instead the curator of the dataverse where the dataset/file has been published will get a notification about requested access to a restricted file.)

...a little to try to keep the section's "you" language and perspective and emphasize that the user gets the notification if she published the dataset but not if she submitted it for review:

Another Dataverse user has requested access to restricted files in a dataset that you published (if you submitted the dataset for review and weren't able to publish it, the curators of the dataverse that contains your dataset will get a notification about requests to access your restricted files.)

How does that sound?

Reworded to keep the section's "you" language and perspective and emphasize that the user gets the notification if she published the dataset but not if she submitted it for review.
@philippconzett
Copy link
Contributor Author

Thanks, @jggautier! I think the request access to restricted file feature is only available for published datasets, so I think we should change the text in brackets slightly. Here's my suggestion:

Another Dataverse user has requested access to restricted files in a dataset that you published (if your dataset was (reviewed and) published by a curator, the curators of the dataverse that contains your dataset will get a notification about requests to access your restricted files.)

@jggautier
Copy link
Contributor

@philippconzett, I see your point. Could you take a look at the latest changes?

@djbrooke, once the update is finished, do I move this to the QA column?

@djbrooke
Copy link
Contributor

djbrooke commented Jul 9, 2020

@jggautier if you and @philippconzett are OK with it feel free to move it on. Thank you to you both!

Copy link
Contributor Author

@philippconzett philippconzett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jggautier jggautier removed their assignment Jul 9, 2020
@kcondon kcondon self-assigned this Jul 13, 2020
@kcondon kcondon merged commit 378aaad into IQSS:develop Jul 13, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jul 13, 2020
@djbrooke djbrooke added this to the Dataverse 5 milestone Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Addition to User Guide
5 participants