Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting clean up to resolve warnings in sphinx builds [ref #7066] #7071

Merged
merged 1 commit into from Jul 10, 2020
Merged

Formatting clean up to resolve warnings in sphinx builds [ref #7066] #7071

merged 1 commit into from Jul 10, 2020

Conversation

mheppler
Copy link
Contributor

@mheppler mheppler commented Jul 9, 2020

What this PR does / why we need it:

Formatting clean to resolve warnings in sphinx builds

Which issue(s) this PR closes:

Closes #7066 GUIDES REDUX: Misc sphinx-guides formatting clean up

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@mheppler mheppler requested a review from donsizemore July 9, 2020 20:52
@mheppler mheppler changed the title Formatting clean to resolve warnings in sphinx builds [ref #7066] Formatting clean up to resolve warnings in sphinx builds [ref #7066] Jul 9, 2020
pdurbin
pdurbin approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test these changes but I think they look fine.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ Jul 9, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.653% when pulling 61c3e0b on 7066-dev-guide-cleanup into 0636726 on develop.

@kcondon kcondon assigned kcondon and unassigned kcondon Jul 10, 2020
@kcondon kcondon merged commit 20c85a9 into develop Jul 10, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jul 10, 2020
@kcondon kcondon deleted the 7066-dev-guide-cleanup branch July 10, 2020 14:28
@djbrooke djbrooke added this to the Dataverse 5 milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdurbin pdurbin pdurbin approved these changes

@donsizemore donsizemore Awaiting requested review from donsizemore

Assignees

@kcondon kcondon

Labels
None yet
Projects
No open projects
IQSS/dataverse (TO BE RETIRED / DELET...
Done 🚀
Milestone
Dataverse 5
Development

Successfully merging this pull request may close these issues.

GUIDES REDUX: Misc sphinx-guides formatting clean up
5 participants
@mheppler @coveralls @pdurbin @kcondon @djbrooke