allow publishing and OpenAire export when first name is missing for author #7059 #7098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If the author is entered with an empty comma-separated first name, like this: "Smith," it results in a fatal error in the OpenAire export, making it impossible to publish the dataset.
Which issue(s) this PR closes:
Closes #7059
Special notes for your reviewer:
An ArrayIndexOutOfBoundsException was being thrown.
Suggestions on how to test this:
For me, it wasn't enough to type "Smith," as the author name. I had to turn on ORCID (no ORCID ID required) like this:
(There's existing logic in the code that the presence of an ORCID indicates a person rather than an organization.)
The expected behavior:
[2020-07-17T14:39:26.076-0400] [Payara 5.201] [INFO] [] [edu.harvard.iq.dataverse.export.openaire.OpenAireExportUtil] ... [[Unable to write givenName and familyName based on creatorName 'Smith, '.]]
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No. Just a bug fix. An ArrayIndexOutOfBoundsException was being thrown and now there is an additional check on the size of the array before indexing into it.
Additional documentation:
None.