Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ec2-create-instance.sh downloadable #7099 #7100

Merged
merged 1 commit into from Jul 20, 2020
Merged

make ec2-create-instance.sh downloadable #7099 #7100

merged 1 commit into from Jul 20, 2020

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Jul 17, 2020

What this PR does / why we need it:

Users can't download ec2-create-instance.sh without it.

Which issue(s) this PR closes:

Closes #7099

Special notes for your reviewer:

:download: only works on local files, which is why I'm changing it.

Suggestions on how to test this:

Build the docs. Make sure you can download the script.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

No.

Additional documentation:

None.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.623% when pulling 4417a02 on 7099-docs into c9ec158 on develop.

Copy link
Contributor

@mheppler mheppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdurbin Suggesting a format revision to keep with the format more commonly used in the guides already.

Copy link
Contributor

@mheppler mheppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. Resolved comment with previously requested changes based on feedback from @pdurbin that I missed an important detail which renders my suggestion moot.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ Jul 20, 2020
@kcondon kcondon merged commit 941d17d into develop Jul 20, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jul 20, 2020
@kcondon kcondon deleted the 7099-docs branch July 20, 2020 22:00
@djbrooke djbrooke added this to the Dataverse 5 milestone Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

ec2 script can't be downloaded from the docs
6 participants