Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7079 guides download all and analytics #7110

Merged
merged 5 commits into from Jul 28, 2020

Conversation

mheppler
Copy link
Contributor

What this PR does / why we need it:

  • Adds reference to new Access Dataset btn and download all files feature to the User Guide.
  • Adds function to strip download size of ZIP from the link text sent to analytics reports when tracking clicks of said new download all files links under Access Dataset btn, to the sample code provided in the Installation Guide.

Which issue(s) this PR closes:

Closes #7079 Access Dataset + Download "All Files" - Update Guides and Analytics

Special notes for your reviewer:

N/A

Suggestions on how to test this:

Need to configure analytics, using new sample code provided in Installation Guide, should see "Original Format ZIP" and "Archival Format (.tab) ZIP" recorded in the analytics reports.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

N/A

Is there a release notes update needed for this change?:

Need release notes notifying sysadmins to update their analytics code if configured already, so the file size "(5.1 MB)" is not included in the Event Category recorded in the Google Analytics reports.

Additional documentation:

N/A

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.61% when pulling 2ac69d7 on 7079-guides-download-all-and-analytics into 941d17d on develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't test the analytics code but it's trying to do makes sense.

@@ -117,9 +119,6 @@ Ingested files can be downloaded in several different ways.

- The variable metadata for the file in DDI format

- A subset of the columns of the data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I assume we forgot to remove this line about subset as part of #6098.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ Jul 22, 2020
Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@djbrooke djbrooke added this to the Dataverse 5 milestone Jul 24, 2020
@kcondon
Copy link
Contributor

kcondon commented Jul 28, 2020

@mheppler Quick question, should https://raw.githubusercontent.com/IQSS/dataverse/2ac69d7503d12a1013530683db4dbcbb9b8bb969/doc/sphinx-guides/source/_static/installation/files/var/www/dataverse/branding/analytics-code.html be downloadable from the guides? I see analytics-code.html highlighted but not downloadable.
Ah, there are two places where it is mentioned and highlighted: 1. in the initial section on analytics code with sample, then in the track buttons section where it is a downloadable link. Not sure why one is a link and one isn't or why they're both bolded but one highlighted and one a link.

@kcondon kcondon self-assigned this Jul 28, 2020
@kcondon kcondon merged commit 352b17f into develop Jul 28, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jul 28, 2020
@kcondon kcondon deleted the 7079-guides-download-all-and-analytics branch July 28, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Access Dataset + Download "All Files" - Update Guides and Analytics
6 participants