7112 payara5 aio #7114
Merged
7112 payara5 aio #7114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added this to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
pdurbin
approved these changes
Jul 22, 2020
|
|
||
| if [ ! -e dv/deps/payara-5.2020.2.zip ]; then | ||
| echo "payara dependency prep" | ||
| # no more fiddly patching :) |
| # yeah - still not happy if glassfish isn't in /usr/local :< | ||
| RUN ln -s /opt/glassfish4 /usr/local/glassfish4 | ||
| # keeping the symlink on the off chance that something else is still assuming /usr/local/glassfish4 | ||
| RUN ln -s /opt/payara5 /usr/local/glassfish4 |
There was a problem hiding this comment.
I assume it's safe to not create this symlink. But it doesn't hurt to leave it in. I'm glad the comment was updated to described what's going on.
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Code Review 🦁
to QA 🔎✅
Jul 22, 2020
pameyer
moved this from QA 🔎✅
to Community Dev 💻❤️
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
Found that this does not work on a fresh system due to absence of glassfish-setup.sh ; was accidentally working on a dev system that still had a cached copy. |
It's still there but it was renamed to as-setup.sh. |
donsizemore
pushed a commit
to uncch-rdmc/dataverse
that referenced
this pull request
Jul 29, 2020
|
updated and re-tested |
pameyer
moved this from Community Dev 💻❤️
to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
|
@pdurbin sorry about that - thanks for catching it! |
pdurbin
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
Looking good. I see Payara, as expected:
$ curl -i http://localhost:8083/api/info/version
HTTP/1.1 200 OK
Server: Payara Server 5.2020.2 #badassfish
X-Powered-By: Servlet/4.0 JSP/2.3 (Payara Server 5.2020.2 #badassfish Java/Oracle Corporation/1.8)
Access-Control-Allow-Origin: *
Access-Control-Allow-Methods: PUT, GET, POST, DELETE, OPTIONS
Access-Control-Allow-Headers: Content-Type, X-Dataverse-Key
Content-Type: application/json;charset=UTF-8
Content-Length: 78
X-Frame-Options: SAMEORIGIN
{"status":"OK","data":{"version":"4.20","build":"7112-payara5_aio-5a77f49f7"}}
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Code Review 🦁
to QA 🔎✅
Aug 3, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
switch docker-aio from glassfish to payara
Which issue(s) this PR closes:
Closes #7112
Special notes for your reviewer:
Deferred testing of / changes related to new install script (despite describing it as analogous to an issues that explicitly included testing the new installer); focused on API test suite.
Suggestions on how to test this:
Existing instructions for docker-aio should work unchanged; Server header from
curl -i http://localhost:8083/api/info/versionshould report payaraDoes this PR introduce a user interface change? If mockups are available, please link/include them here:
nope
Is there a release notes update needed for this change?:
nope
Additional documentation:
should be none necessary