Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add useradd dataverse to prerequisites.rst #7131

Merged
merged 2 commits into from Jul 27, 2020

Conversation

donsizemore
Copy link
Contributor

What this PR does / why we need it: installation instructions mention creating a dataverse service account but don't provide an example command

Which issue(s) this PR closes:

Closes #7095

Special notes for your reviewer: none

Suggestions on how to test this: run the command

Does this PR introduce a user interface change? If mockups are available, please link/include them here: no

Is there a release notes update needed for this change?: no

Additional documentation: none

@coveralls
Copy link

coveralls commented Jul 24, 2020

Coverage Status

Coverage remained the same at 19.61% when pulling 627a04d on OdumInstitute:7095_useradd_dataverse into 941d17d on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you preview the doc on GitHub or build locally, you'll see that useradd dataverse isn't indented:

Screen Shot 2020-07-27 at 4 08 45 PM

I suggested a fix.

@@ -52,7 +52,9 @@ Payara 5.2020.2 is recommended. Newer versions might work fine.
Installing Payara
=================

**Note:** The Dataverse installer need not be run as root, and it is recommended that Payara not run as root either. We suggest the creation of a "dataverse" service account for this purpose.
**Note:** The Dataverse installer need not be run as root, and it is recommended that Payara not run as root either. We suggest the creation of a "dataverse" service account for this purpose:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Note:** The Dataverse installer need not be run as root, and it is recommended that Payara not run as root either. We suggest the creation of a "dataverse" service account for this purpose:
**Note:** The Dataverse installer need not be run as root, and it is recommended that Payara not run as root either. We suggest the creation of a "dataverse" service account for this purpose::

@pdurbin pdurbin moved this from Code Review 🦁 to Community Dev 💻❤️ in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jul 27, 2020
@pdurbin pdurbin moved this from Community Dev 💻❤️ to Code Review 🦁 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jul 27, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ Jul 27, 2020
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as of 627a04d

@kcondon kcondon self-assigned this Jul 27, 2020
@kcondon kcondon merged commit baa521d into IQSS:develop Jul 27, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jul 27, 2020
@pdurbin pdurbin added this to the Dataverse 5 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

useradd dataverse (Glassfish/Payara user) missing from the docs
4 participants