Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RestAssured tests broken by #6918 #7159

Closed
landreev opened this issue Aug 4, 2020 · 0 comments · Fixed by #7165
Closed

Fix RestAssured tests broken by #6918 #7159

landreev opened this issue Aug 4, 2020 · 0 comments · Fixed by #7165
Assignees
@landreev
Milestone
Dataverse 5

Comments

@landreev
Copy link
Contributor

landreev commented Aug 4, 2020

The PR required extra RestAssured code to accommodate the changed publish behavior. It wasn't included so it broke the tests.
This issue is to handle the followup PR to fix it.
Also, per discussion with @scolapasta, addressing the long Sleep statement in the Dataset service bean, by moving the execution of the finalize command to the onSuccess() part of the PublishDataset command.
@djbrooke djbrooke added this to the Dataverse 5 milestone Aug 4, 2020
@landreev landreev self-assigned this Aug 5, 2020
landreev added a commit that referenced this issue Aug 5, 2020
@landreev
Followup fixes for PR #6918. Missing additions to UtilIT.java needed …
a0d94a4 
…for RestAssured to work;

but also some changes for the application proper to address some problematic things in the
execution framework of the publish commands. Will explain more in the PR. (#7159)
@landreev landreev mentioned this issue Aug 6, 2020
Merged
landreev added a commit that referenced this issue Aug 6, 2020
@landreev
Fix for the transaction context in the finalize command execution;
d15fa77 
Moved the unlock calls back to the end of the execute method. #7159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@landreev landreev

Labels
None yet
Projects
None yet
Milestone
Dataverse 5
Development

Successfully merging a pull request may close this issue.

7159 fix restassured etc IQSS/dataverse
2 participants
@landreev @djbrooke