Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7046 dataverse 5 release notes #7164

Merged
merged 36 commits into from Aug 17, 2020
Merged

Conversation

djbrooke
Copy link
Contributor

@djbrooke djbrooke commented Aug 6, 2020

What this PR does / why we need it:

The release notes for Dataverse 5!

Which issue(s) this PR closes:

Closes #7046

Special notes for your reviewer:

No longer a draft PR. Thanks for all the feedback so far!

Suggestions on how to test this:

Bring it into your favorite text editor and take a look.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

N/A

Is there a release notes update needed for this change?:

N/A

Additional documentation:

N/A

@djbrooke djbrooke marked this pull request as draft August 6, 2020 00:35
@coveralls
Copy link

coveralls commented Aug 6, 2020

Coverage Status

Coverage remained the same at 19.561% when pulling 12bb8fc on 7046-dataverse-5-release-notes into 30f4c30 on develop.

@djbrooke djbrooke added this to the Dataverse 5 milestone Aug 6, 2020
@pdurbin pdurbin self-assigned this Aug 6, 2020
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to accept all these changes. I'm exhausted now but I might take another look later.

doc/release-notes/5.0-release-notes.md Outdated Show resolved Hide resolved
doc/release-notes/5.0-release-notes.md Outdated Show resolved Hide resolved
doc/release-notes/5.0-release-notes.md Outdated Show resolved Hide resolved
doc/release-notes/5.0-release-notes.md Outdated Show resolved Hide resolved
doc/release-notes/5.0-release-notes.md Outdated Show resolved Hide resolved
doc/release-notes/5.0-release-notes.md Outdated Show resolved Hide resolved
doc/release-notes/5.0-release-notes.md Outdated Show resolved Hide resolved
doc/release-notes/5.0-release-notes.md Outdated Show resolved Hide resolved
doc/release-notes/5.0-release-notes.md Outdated Show resolved Hide resolved
doc/release-notes/5.0-release-notes.md Outdated Show resolved Hide resolved
@pdurbin pdurbin removed their assignment Aug 6, 2020
@djbrooke djbrooke self-assigned this Aug 7, 2020
@djbrooke
Copy link
Contributor Author

djbrooke commented Aug 7, 2020

@pdurbin and @qqmyers thanks for the excellent feedback. I made a large percentage of the changes that you suggested. These release notes are indeed a 🐻 .

@qqmyers I'll respond to your comment about doi.baseurlstringnext above.

@djbrooke djbrooke marked this pull request as ready for review August 13, 2020 19:02
@djbrooke djbrooke assigned landreev and unassigned djbrooke Aug 13, 2020

<http://guides.dataverse.org/en/5.0/admin/metadataexport.html?highlight=export#batch-exports-through-the-api>

17. For installations using DataCite, pre-register DOIs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is already a detailed section for this step, above - does it need to be here, in the upgrade-to-payara instruction - probably not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've done this previously, that is, added it in the notes above and called out and individual step.

I added a (Recommended for installations using DataCite) at the start of the instruction. I also added a note for Add doi.dataciterestapiurlstring

Let me know what you think following the updates in abc4d9b

done
```

18. Set up Standalone Zipper Service if desired. Please consult the scripts/zipdownload/README.md in the Dataverse 5 source tree for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly, this is already explained in its own section above - not sure it needs to be repeated in the upgrade-to-payara instruction - ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the experimental note in abc4d9b. I think it's fine to add this in two different instruction formats and it matches what we've done in previous notes but if you feel strongly I can revisit. I don't do the upgrades myself so if this sort of thing is not helpful to mention multiple times I'm fine to adjust it.

@donsizemore
Copy link
Contributor

@landreev on Xmx and Xms - perhaps the paragraph should've begun with "Adjust" or "Review" rather than set. The step was included a recommendation in the performance tuning document but I'm fine with having it removed, especially if it will cause confusion.

@kcondon kcondon self-assigned this Aug 17, 2020
@kcondon kcondon merged commit 63a9a7c into develop Aug 17, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Aug 17, 2020
@kcondon kcondon deleted the 7046-dataverse-5-release-notes branch August 17, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Dataverse 5 Release Notes
7 participants