Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed publish btn dropdown display [ref #7183] #7191

Merged
merged 1 commit into from Aug 13, 2020

Conversation

mheppler
Copy link
Contributor

What this PR does / why we need it:

Extra dropdown-toggle style class snuck into the single-click version of the Publish btn, which triggered the display of the dropdown menu under the button when clicked.

Which issue(s) this PR closes:

Closes #7183 Extraneous Publish Option on Release Candidate

Special notes for your reviewer:

See screenshot in original issue for how the single-click version of the Publish btn should NOT look.

Suggestions on how to test this:

When you click the Publish btn on a dataset with no Submit For Review set up, you should NOT see the dropdown menu displayed, as the screenshot in the original issue shows. If you see a dropdown carrot icon in the button for a dataset WITH the Submit For Review workflow set up, then you should see the dropdown menu, showing the Publish or Return To Author options.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

It fixes a UI bug, returning the page to intended functionality, this is not a change in design.

Is there a release notes update needed for this change?:

No.

Additional documentation:

N/A

@mheppler mheppler added this to the Dataverse 5 milestone Aug 12, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.562% when pulling e808e14 on 7183-extraneous-publish-option into 2d632ae on develop.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ Aug 12, 2020
@kcondon kcondon self-assigned this Aug 13, 2020
@kcondon kcondon merged commit c18f6cf into develop Aug 13, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Aug 13, 2020
@kcondon kcondon deleted the 7183-extraneous-publish-option branch August 13, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Extraneous Publish Option on Release Candidate
4 participants