Iqss/7189 i18n terms default #7192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbrooke
added this to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
scolapasta
approved these changes
Aug 12, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Code Review 🦁
to QA 🔎✅
Aug 12, 2020
djbrooke
moved this from QA 🔎✅
to Code Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
scolapasta
approved these changes
Aug 12, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Code Review 🦁
to QA 🔎✅
Aug 12, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Uses the defaultLocale value for the ApplicationTermsOfUse as the default if set when a language specific value doesn't exist.
Which issue(s) this PR closes:
Closes #7189
Special notes for your reviewer:
Suggestions on how to test this: Check the issue - I think you'll have to set your browser/machine to have a different default language. Once you do that, you can confirm that you see the terms set for the :ApplicationTermsOfUse setting instead of what's written in Bundle.properties for the system.app.terms value (which is what will show in the sign-up page prior to this PR).
Does this PR introduce a user interface change? If mockups are available, please link/include them here: ~no - just shows a better default for terms.
Is there a release notes update needed for this change?: no
Additional documentation: