Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7195 fix test #7198

Merged
merged 3 commits into from Aug 14, 2020
Merged

7195 fix test #7198

merged 3 commits into from Aug 14, 2020

Conversation

scolapasta
Copy link
Contributor

What this PR does / why we need it:
fixes failing tests

Which issue(s) this PR closes:

Closes #7195

Special notes for your reviewer:
Assertions checked for error which seems sufficient, rather than specific message (which could change and break test)
(also added sleep for lock for ExternalTools test that was failing intermittently)

Suggestions on how to test this:
Make sure integration tests pass

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no

Is there a release notes update needed for this change?:
no

Additional documentation:

@scolapasta scolapasta added this to the Dataverse 5 milestone Aug 13, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.561% when pulling 93f451a on 7195-fix-test into 30f4c30 on develop.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Code Review 🦁 to QA 🔎✅ Aug 13, 2020
@landreev landreev merged commit 1822683 into develop Aug 14, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Aug 14, 2020
@landreev landreev deleted the 7195-fix-test branch August 14, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

DownloadFilesIT/downloadAllFilesRestricted Failing on build 555
3 participants