New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset page - button and citations display issues in different languages #7326
Comments
🤦 Apologies, @kaitlinnewson. I thought this was addressed. I can look into this and get it prioritized ASAP. ATTN @djbrooke. |
@kaitlinnewson thanks for the report, we can take a look |
To frame discussion a bit, it seems like there are ~3 directions that could be pursued, alone or in some combination:
|
Submitted a PR #7535 to improve the display of long button label text, so that any overflow is no longer hidden by the container button width. While @qqmyers brings up some good points above to address this issue, this quick code fix might be the most appropriate to resolve the issues reported by @kaitlinnewson above. |
@kaitlinnewson Do you have a test Bundle_fr.properties file I can use to test with? |
@kcondon This one should hopefully work. It's for 5.1.1 so may have some missing strings: https://github.com/scholarsportal/dataverse-language-packs/blob/dataverse-v5.1.1-SP/fr_CA/Bundle_fr.properties |
Actually we did shorten some strings to make them fit in the 5.1.1 version, so this one should be better for testing the issue: https://github.com/scholarsportal/dataverse-language-packs/blob/dataverse-v5.0-SP/fr_CA/Bundle_fr.properties |
@kaitlinnewson Thanks, that works. |
Fix btn text word wrap, other responsive layout improvements [ref #7326]
Hi Dataverse team,
We at Scholars Portal have begun testing Dataverse 5 (currently 5.0 and working on our merge up to 5.1.1, so apologies if this was already addressed). We have noticed an issue with the display of buttons and citations on the dataset page when we change languages to French.
The new design does not seem to accommodate longer strings of text.
Has the new dataset page been previously tested with different languages? We only use EN/FR, but I can see this happening with other languages too.
The text was updated successfully, but these errors were encountered: