Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset page - button and citations display issues in different languages #7326

Closed
kaitlinnewson opened this issue Oct 13, 2020 · 8 comments · Fixed by #7535
Closed

Dataset page - button and citations display issues in different languages #7326

kaitlinnewson opened this issue Oct 13, 2020 · 8 comments · Fixed by #7535

Comments

@kaitlinnewson
Copy link
Contributor

Hi Dataverse team,

We at Scholars Portal have begun testing Dataverse 5 (currently 5.0 and working on our merge up to 5.1.1, so apologies if this was already addressed). We have noticed an issue with the display of buttons and citations on the dataset page when we change languages to French.

Screen Shot 2020-10-13 at 4 59 28 PM

The new design does not seem to accommodate longer strings of text.

Has the new dataset page been previously tested with different languages? We only use EN/FR, but I can see this happening with other languages too.

@mheppler
Copy link
Contributor

🤦

Apologies, @kaitlinnewson. I thought this was addressed. I can look into this and get it prioritized ASAP. ATTN @djbrooke.

@djbrooke
Copy link
Contributor

@kaitlinnewson thanks for the report, we can take a look

@djbrooke djbrooke moved this from Up Next 🛎 to Needs Discussion 💬 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Oct 14, 2020
@qqmyers
Copy link
Member

qqmyers commented Dec 1, 2020

To frame discussion a bit, it seems like there are ~3 directions that could be pursued, alone or in some combination:

  • Maximizing the length allowed in the display through UI changes, e.g. either with bigger spaces, or something adaptive such as allowing word wrap to expand a button. While it would be difficult to handle truly arbitrary length text and keep the UI looking reasonable, if there are only a few problematic places and handling length of 1.5x to 2x of the existing length is enough, this could work. It might still be hard to avoid whitespace for short translations, etc.
  • Review the translations and come up with shorter ones - may or may not be possible to do without reducing how clear the meaning is, and I don't think there is currently any documentation about length limits
  • Consider some form of progressive disclosure, e.g. showing the first n characters and, upon hovering, show the full label as a popup. This can be a bit tricky (truncate at word boundaries? and in the first word if it is too long?) and can also limit comprehension unless the translations are made with this in mind.

@mheppler mheppler self-assigned this Jan 21, 2021
@mheppler mheppler moved this from Needs Discussion/Definition 💬 to Up Next 🛎 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jan 21, 2021
@mheppler mheppler added the Small label Jan 21, 2021
@mheppler mheppler moved this from Up Next 🛎 to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Jan 22, 2021
mheppler added a commit that referenced this issue Jan 25, 2021
@mheppler mheppler removed their assignment Jan 25, 2021
@mheppler
Copy link
Contributor

Submitted a PR #7535 to improve the display of long button label text, so that any overflow is no longer hidden by the container button width.

While @qqmyers brings up some good points above to address this issue, this quick code fix might be the most appropriate to resolve the issues reported by @kaitlinnewson above.

Screen Shot 2021-01-25 at 2 05 19 PM

mheppler added a commit that referenced this issue Jan 28, 2021
@kcondon
Copy link
Contributor

kcondon commented Jan 29, 2021

@kaitlinnewson Do you have a test Bundle_fr.properties file I can use to test with?

@kaitlinnewson
Copy link
Contributor Author

@kcondon This one should hopefully work. It's for 5.1.1 so may have some missing strings: https://github.com/scholarsportal/dataverse-language-packs/blob/dataverse-v5.1.1-SP/fr_CA/Bundle_fr.properties

@kaitlinnewson
Copy link
Contributor Author

Actually we did shorten some strings to make them fit in the 5.1.1 version, so this one should be better for testing the issue: https://github.com/scholarsportal/dataverse-language-packs/blob/dataverse-v5.0-SP/fr_CA/Bundle_fr.properties

@kcondon
Copy link
Contributor

kcondon commented Jan 29, 2021

@kaitlinnewson Thanks, that works.

kcondon added a commit that referenced this issue Jan 29, 2021
Fix btn text word wrap, other responsive layout improvements [ref #7326]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants