Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document default zip upload files limit, provide curl example #7444

Merged

Conversation

donsizemore
Copy link
Contributor

What this PR does / why we need it: the ZipUploadFilesLimit setting defaults to 1,000 but this isn't documented in the configuration guide.

Which issue(s) this PR closes:

Closes #7442

Special notes for your reviewer: none

Suggestions on how to test this: just a doc change

Does this PR introduce a user interface change? If mockups are available, please link/include them here: no

Is there a release notes update needed for this change?: no

Additional documentation: none

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (thanks for the curl example!) and I confirmed that the default limit is 1000:

https://github.com/IQSS/dataverse/blob/v5.2/src/main/java/edu/harvard/iq/dataverse/util/SystemConfig.java#L95

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Nov 30, 2020
@kcondon kcondon self-assigned this Nov 30, 2020
@kcondon kcondon merged commit 78208e5 into IQSS:develop Nov 30, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Nov 30, 2020
@djbrooke djbrooke added this to the 5.3 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

ZipUploadFilesLimit defaults to 1000
4 participants