Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7439 - 5.3 release notes #7446

Merged
merged 17 commits into from Dec 10, 2020
Merged

7439 - 5.3 release notes #7446

merged 17 commits into from Dec 10, 2020

Conversation

djbrooke
Copy link
Contributor

@djbrooke djbrooke commented Dec 1, 2020

What this PR does / why we need it:

The release notes for the 5.3 pre-holiday break release spectacular. 🎁

Which issue(s) this PR closes:

Closes #7439

Special notes for your reviewer:

  • Please check my usage of "obsolete" in regards to the DB settings for banner management. Not sure if it should be obsolete or deprecated, or something else.
  • Please check where I put the Payara upgrade in the release steps. I put it after "Undeploy the Previous Version" this was handled in the updates for a later release note from @poikilotherm

Suggestions on how to test this:

Lint check, grammar/spelling check. :)

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

N/A

Is there a release notes update needed for this change?:

Meta

Additional documentation:

N/A

@djbrooke djbrooke marked this pull request as draft December 1, 2020 19:35
@djbrooke
Copy link
Contributor Author

djbrooke commented Dec 1, 2020

@coveralls
Copy link

coveralls commented Dec 1, 2020

Coverage Status

Coverage increased (+0.02%) to 19.419% when pulling 02215f1 on 7439-5.3-release-notes into da19bcf on develop.

@djbrooke djbrooke moved this from Review 🦁 to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Dec 7, 2020
@djbrooke djbrooke self-assigned this Dec 7, 2020
@djbrooke djbrooke marked this pull request as ready for review December 8, 2020 23:03
@djbrooke
Copy link
Contributor Author

djbrooke commented Dec 8, 2020

@scolapasta @poikilotherm and others - ready for more review here. Thanks for the reviews so far!

@djbrooke djbrooke moved this from IQSS Team - In Progress 💻 to Review 🦁 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Dec 8, 2020
@djbrooke djbrooke removed their assignment Dec 8, 2020
Copy link
Contributor

@poikilotherm poikilotherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

It would be great if we can add #7457 / #7463 to this release, as it explains a lot about the why and how related to MPCONFIG.
@pdurbin was already satisfied and this doesn't change a thing for anyone, as this is groundwork to enable further steps.

Copy link
Contributor

@scolapasta scolapasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes, adding /bin/ where needed, and a consistency change

doc/release-notes/5.3-release-notes.md Outdated Show resolved Hide resolved
doc/release-notes/5.3-release-notes.md Outdated Show resolved Hide resolved
doc/release-notes/5.3-release-notes.md Outdated Show resolved Hide resolved
@djbrooke djbrooke moved this from Review 🦁 to IQSS Team - In Progress 💻 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Dec 9, 2020
@djbrooke djbrooke self-assigned this Dec 9, 2020
@djbrooke djbrooke moved this from IQSS Team - In Progress 💻 to Review 🦁 in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) Dec 9, 2020
@djbrooke djbrooke removed their assignment Dec 9, 2020
@djbrooke djbrooke added this to the 5.3 milestone Dec 9, 2020
Copy link
Contributor

@scolapasta scolapasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready for release!

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Dec 9, 2020
@kcondon kcondon self-assigned this Dec 10, 2020
@kcondon kcondon merged commit c84ab07 into develop Dec 10, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Dec 10, 2020
@kcondon kcondon deleted the 7439-5.3-release-notes branch December 10, 2020 17:22
sekmiller added a commit that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5.3 Release Notes
6 participants