Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce using MicroProfile Config API #7457

Closed
poikilotherm opened this issue Dec 4, 2020 · 1 comment · Fixed by #7463
Closed

Introduce using MicroProfile Config API #7457

poikilotherm opened this issue Dec 4, 2020 · 1 comment · Fixed by #7463
Labels
Feature: Admin Guide Feature: Installation Guide Feature: Installer Type: Feature a feature request User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh
Projects
IQSS/dataverse (TO BE RETIRED / DELET...

Comments

@poikilotherm
Copy link
Contributor

poikilotherm commented Dec 4, 2020 •
edited

This is a story for epic #7000
This could be done as part of #7424, but as we prefer more narrow scopes, don't.

As you might have noticed, #7422 is about to introduce the first pieces to bring us the joy of MicroProfile Config API without calling ourselves a microservice.

This issue is about paving the ground to enable #7424 profit from it and offer full configuration flexibility.

We will introduce:

  • Maven dependencies for using the API
  • A test dependency for running unit and integration tests with an API implementation but without deploying to a full fledged appserver
  • Allow moving and renaming of config, but remain backward-compatible:
    • A config source to enable aliases, as we are likely to rename a few "JVM properties"
    • A config source to allow moving some database settings to MicroProfile Config
    • Scenario: make the old settings deprecated and log their use, giving hints about migration
@poikilotherm poikilotherm added Feature: Admin Guide Feature: Installer Feature: Installation Guide Type: Feature a feature request User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh labels Dec 4, 2020
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 4, 2020
@poikilotherm
Move SystemConfig to new package util.config as a new place where Con…
c096242 
…figSources live next to it. IQSS#7457
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 7, 2020
@poikilotherm
Introducing an MPCONFIG alias config source. IQSS#7457
a535ce8
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 7, 2020
@poikilotherm
Add missing name to AliasConfigSource. IQSS#7457
7a2433e
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 7, 2020
@poikilotherm
Refactor AliasConfigSource to be more testable and rename aliases fil…
620e9ab 
…e to microprofile-aliases.properties. IQSS#7457
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 7, 2020
@poikilotherm
Fix error in AliasConfigSource, not looking at keys but values of the…
ebf83e2 
… map. IQSS#7457
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 7, 2020
@poikilotherm
Add tests for AliasConfigSource. IQSS#7457
e1cb339
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 8, 2020
@poikilotherm
Add integration testing for DbSettingConfigSource to ensure data retr…
8790313 
…ieval works. Fixing a typo, too. IQSS#7457
@poikilotherm poikilotherm mentioned this issue Dec 8, 2020
Merged
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 8, 2020
@poikilotherm
Add integration testing for DbSettingConfigSource to ensure data retr…
fdb043d 
…ieval works. Fixing a typo, too. IQSS#7457
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 8, 2020
@poikilotherm
Change pom.xml to include the MicroProfile Config API SPI definitions. …
b1ea846 
…IQSS#7457
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 8, 2020
@poikilotherm
Extend dev docs about MPCONFIG. IQSS#7457
5f73b45
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 8, 2020
@poikilotherm
Fix DbSettingConfigSource not to throw an exception if the DataSource…
2ffa4c1 
… JNDI could not be found or injected. Will result empty properties for this source. IQSS#7457
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 8, 2020
@poikilotherm
More dev documentation of MPCONFIG usage and sources. IQSS#7457
e6f38ee
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 8, 2020
@poikilotherm
Add release notes for IQSS#7457
ffe775e
poikilotherm added a commit to poikilotherm/dataverse that referenced this issue Dec 8, 2020
@poikilotherm
Add javadoc about what is DbSettingConfigHelper. IQSS#7457
00b9533
pdurbin added a commit to poikilotherm/dataverse that referenced this issue Dec 9, 2020
@pdurbin
add toc IQSS#7457
f135050
@poikilotherm poikilotherm mentioned this issue Dec 9, 2020
Closed
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Community Dev 💻❤️ to Done 🚀 Dec 10, 2020
@poikilotherm
Copy link
Contributor Author

🤩 🤩 🤩 🤩 🤩

Thank you for merging @kcondon ! Much appreciated, as always!

@poikilotherm poikilotherm mentioned this issue Jun 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: Admin Guide Feature: Installation Guide Feature: Installer Type: Feature a feature request User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh
Projects
No open projects
IQSS/dataverse (TO BE RETIRED / DELET...
Done 🚀
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

7457 introduce mpconfig poikilotherm/dataverse
1 participant
@poikilotherm