7130-handle missing contact name #7465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
pdurbin
approved these changes
Dec 8, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Dec 8, 2020
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR handles the case where a contact has an email but not a name which previously resulted in a null pointer exception.
Which issue(s) this PR closes:
Closes #7130
Special notes for your reviewer: discussion in issue. Note this branch was merged once to close 7130 - reusing the issue and branch to handle another point that has come up.
Suggestions on how to test this: create a dataset with a contact that only has an email. Publish. Trigger bag creation (probably easiest to configure the file archiver and then use the API to request bag creation - per guides). Bag should be created. (@mderuijter may also be able to test?)
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?: no
Additional documentation: none