New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Notes Update: Timer #7481
Conversation
@@ -132,27 +132,37 @@ Please configure your connection details, replacing all the `${DB_...}`. | |||
- `<payara install path>/bin/asadmin create-password-alias --passwordfile /tmp/password.txt dataverse.db.password` | |||
- `rm /tmp/password.txt` | |||
|
|||
4\. Reset the EJB timer database back to default: | |||
4\. Replace relevant portions of domain.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this step is only necessary for those who are coming from what was originally a glassfish4 domain.xml. (and if we also do add this to the 5.0 release notes, per the multiple server issue from the mailing list, we may want text like "if you haven't already done this during the 5.0 release, it is now necessary due to the changes to how ejb timers are now handled". we can discuss this in person, if you'd like to understand this better - the whys and whens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scolapasta sure, I'll take you up on that. It'll be good to talk about this.
Hi, When upgrading from 4.20 (with GF4) to 5.0, we need to do the same changes. SO I think , it will be good to add this step in the 5.0 upgrading steps. Best regards, Michel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for putting all the effort into this!
OK, thanks - I'll move this over to QA and will be happy to update the release notes themselves once it's merged |
What this PR does / why we need it:
Necessary update for the 5.3 release steps.
Which issue(s) this PR closes:
Closes #7480
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: