Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emphasize differences with SWORD auth (vs. native) #7441 #7484

Merged
merged 1 commit into from Jan 5, 2021

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Dec 18, 2020

What this PR does / why we need it:

There has been confusion over how SWORD auth works, especially if you're used to the native API.

Which issue(s) this PR closes:

Closes #7441

Special notes for your reviewer:

In the Google thread @joenio said, "I think would be nice to update the Dataverse API doc with some examples of using SWORD API by code (can be examples in javascript as I sent in last message or python, or other language). Specially to be clear about the authentication differences between native api and sword api." But then later in the issue he didn't ask for code examples. It's easier and more language neutral to just document APIs with curl so that's what I'm sticking with. Plus, this was estimated as a small.

Suggestions on how to test this:

Nothing to test unless you want to try a curl example on that page. SWORD is exercised regularly from the API test suite and this is just a doc change.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

No.

Additional documentation:

None.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.482% when pulling dc1f554 on 7441-sword-auth into 2fd33c5 on develop.

@sekmiller sekmiller self-assigned this Jan 5, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Jan 5, 2021
@kcondon kcondon self-assigned this Jan 5, 2021
@kcondon kcondon merged commit fedc4a9 into develop Jan 5, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jan 5, 2021
@kcondon kcondon deleted the 7441-sword-auth branch January 5, 2021 20:31
@djbrooke djbrooke added this to the 5.4 milestone Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[doc] Emphasize diferences between Dataverse Native API and SWORD API auth mechanism
5 participants