remove worldmap/geoconnect #7409 #7506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdurbin
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
|
Thanks @pdurbin - if someone wants to start reviewing the code that would be great. I'll take a look at docs and add release notes later this afternoon. |
|
Ok - release notes added and docs reviewed. Looks good! Still needs some code review. |
qqmyers
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
While this is large, it looks like everything is a ~straight-forward deletion of Worldmap code and/or simplifying logic in conditional statements to drop the Worldmap special case.
I didn't check every line, but spot checking all seems good and due to the nature of the change, I'd think moving this on to QA would make sense. The things that could break would presumably be around the external tools displays.
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Jan 13, 2021
qqmyers
reviewed
Jan 13, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As explained in #7409 we are removing WorldMap/Geoconnect support from Dataverse.
Which issue(s) this PR closes:
Closes #7409
Special notes for your reviewer:
The issue says to grab a backup but I took this to mean a full database backup. I didn't implement anything special.
Suggestions on how to test this:
Poke around in the area where the Map It (Geoconnect) button used to be as well as the area where you could view maps.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes, maps are gone. The link to create maps is gone.
Is there a release notes update needed for this change?:
Probably a good idea but I didn't add one yet.
Additional documentation:
None.