Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change h4 to h3 on login page #7559

Merged
merged 1 commit into from Jan 29, 2021
Merged

Change h4 to h3 on login page #7559

merged 1 commit into from Jan 29, 2021

Conversation

kaitlinnewson
Copy link
Contributor

What this PR does / why we need it:

Changes the level 4 heading on the login page to a level 3 heading so heading levels aren't being skipped and are properly nested. "Log In" is a level 2 heading.

Which issue(s) this PR closes:

N/A

Special notes for your reviewer:

N/A

Suggestions on how to test this:

Open the "login" page

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

This will introduce a small change with the "Other options" text on the login page, as it will be larger with the default styling being used.

Current version:

Screen Shot 2021-01-28 at 9 10 35 AM

Updated version:

Screen Shot 2021-01-28 at 9 09 43 AM

Is there a release notes update needed for this change?:

No

Additional documentation:

https://www.w3.org/WAI/WCAG21/Techniques/general/G141.html

Copy link
Member

@TaniaSchlatter TaniaSchlatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Kaitlin.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Jan 28, 2021
@TaniaSchlatter TaniaSchlatter removed their assignment Jan 28, 2021
@mheppler mheppler removed their assignment Jan 28, 2021
@kcondon kcondon self-assigned this Jan 29, 2021
@kcondon kcondon merged commit 39e4a94 into IQSS:develop Jan 29, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Jan 29, 2021
@djbrooke djbrooke added this to the 5.4 milestone Jan 29, 2021
@kaitlinnewson kaitlinnewson deleted the patch-6 branch November 8, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants