New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7084 crawlable file access #7579
Conversation
… (version number added to the dir. index) #7084
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Needs to be brought up to date with dev.
OK, will do. |
Going to move this back into dev. temporarily. Per QA, want to investigate a) direct downloading of sub-sub folders and b) maybe returning a 404 when a non-existing folder is requested. |
Tested basic functionality and it works. Had a couple questions/issues:
|
@kcondon
|
@landreev This works for subdir and for non existent folder but now there are no directory listings as part of the download, only blank directories named dirindex |
I wish it were true. As in, it would be preferable not to save these directory listings, and only save the real files in the dataset; nobody really needs them. |
Ah, you pointed me to your above comment, after I reported the issue. ls -la |
What this PR does / why we need it:
This API provides an html view of a dataset as a set of directory indexes of its folder tree, that you can click through or crawl with wget.
Which issue(s) this PR closes:
Closes #7084
Special notes for your reviewer:
There's a long-ish discussion in the issue. It may be easier to read it starting with the last comments, as is always the case with these things.
I suggest to start with the documentation (in the API guide,
doc/sphinx-guides/source/api/native-api.rst
), then consult the discussion in the issue if necessary.Note that the guide entry has images. They will show up when rendered, but not in GitHub previews. They can be viewed in
doc/sphinx-guides/source/api/img
.Suggestions on how to test this:
See the note above. The guide should have enough information to be able to test it.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
yes.
Additional documentation: