Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7205 fix dataset page load #7581

Merged
merged 4 commits into from Feb 5, 2021
Merged

#7205 fix dataset page load #7581

merged 4 commits into from Feb 5, 2021

Conversation

sekmiller
Copy link
Contributor

@sekmiller sekmiller commented Feb 5, 2021

What this PR does / why we need it:
The Dataset Page fails to load when a tabular file has an original file size of null. A one line change assigns a value of zero to the size when it is null so that the page will load properly

Which issue(s) this PR closes:

Closes #7205

Special notes for your reviewer:
This also suppresses the download original at the dataset level if the full size of the original files is zero (none have an original file size.)

Suggestions on how to test this:
Null out the original file size of a tabular file and verify that its dataset page will load.
update datatable set originalfilesize = null where datafile_id = ??;

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
Not really unless we want to remind installations to run the fixmissingoriginalsizes api

Additional documentation:

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test the fix myself but it's small and simple and makes sense.

IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Feb 5, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from Review 🦁 to QA 🔎✅ Feb 5, 2021
@kcondon kcondon self-assigned this Feb 5, 2021
@kcondon kcondon merged commit c9ccad1 into develop Feb 5, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34) automation moved this from QA 🔎✅ to Done 🚀 Feb 5, 2021
@kcondon kcondon deleted the 7205-orig-file-size-null branch February 5, 2021 19:20
@djbrooke djbrooke added this to the 5.4 milestone Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Dataset: Loading dataset page fails with exception if original file size is null, eg. some legacy Murray
5 participants