Remove negative z-index, add position:relative to content block to fix footer overlap bug [ref #7558] #7584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontent block to fix footer overlap bug [ref #7558]
mheppler
added this to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
via automation
|
Little house cleaning after moving the wrong PR into CR. Opened this PR and closing #7583. |
mheppler
moved this from Review 🦁
to IQSS Team - In Progress 💻
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
…r, cleaned up other CSS on structure stylesheet [ref #7558]
mheppler
moved this from IQSS Team - In Progress 💻
to Review 🦁
in IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
scolapasta
approved these changes
Feb 10, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from Review 🦁
to QA 🔎✅
Feb 10, 2021
IQSS/dataverse (TO BE RETIRED / DELETED in favor of project 34)
automation
moved this from QA 🔎✅
to Done 🚀
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In Firefox, the sticky footer of the app was overlapping dropdown menus in the dataset pg files table, specifically the Access File options for a tabular file.
Which issue(s) this PR closes:
Closes #7558 Footer - Links not clickable in Firefox
Special notes for your reviewer:
CSS and z-index are hard.
Suggestions on how to test this:
Make sure it's all good in Firefox, but double check other browsers too. Should be able to click privacy, accessibility and Dataverse Projects. Make sure that the tabular file download options listed in dropdown menu under Access File icon btns are not hidden under the layer that contains the footer.
Make sure the layering of other elements in the app are all kosher, like navbar dropdown menus, popups + background overlays, autocomplete dropdown menus, etc.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Fixes a UI bug. Should look the same.
Is there a release notes update needed for this change?:
Nope.
Additional documentation: