Fixed extra returns copied with api token on account pg [ref #7601] #7603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes odd bug in Firefox where extra returns were added before and after the api token when copied to the clipboard. Also fixes the copy function success from trying to add an "OK" success icon to the copy button.
Which issue(s) this PR closes:
Closes #7601 API Token - Copy to clipboard REDUX
Related to #6039 Copy buttons for API Token and Private URL
Special notes for your reviewer:
To resolve this, rather have the plugin get the token from the
code
element on the pg, I am passing the token directly to the clipboard with a data attributedata-clipboard-text="#{ApiTokenPage.apiToken}"
on the copy button.Suggestions on how to test this:
Make sure you're only getting the single string of the api token from your clipboard, with no additional returns before or aftere. Phil was using the terminal commandline to prove this. Something pasting in a WYSIWYG that formats the text will not show you these odd invisible returns.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: